Rework get_raw_message to return StreamMessage
#1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
add-stream-message
branch
from
3b94425
to
f35f44e
Compare
caspervonb
reviewed
Aug 2, 2024
Jarema
force-pushed
the
add-stream-message
branch
from
f35f44e
to
fcd87c0
Compare
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
add-stream-message
branch
from
fcd87c0
to
35ce517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having separate types returned by
get_raw_messageanddirect_getseems to be unnecessary complicatinon.Also logic for transforming from received Message was not encapsulated.
Signed-off-by: Tomasz Pietrek [email protected]